Drop the ui module and shared/ — nothing imported them - #8
Merged
Conversation
This crate carried a byte-identical copy of SmooAI/ui's design system and described itself as that crate's successor. The migration was never finished, and an org-wide search found NOTHING importing `smooai_client_shared::ui` — the real design-system consumers (smooblue, observability-studio) depend on SmooAI/ui directly, and this crate's one consumer, the `th` CLI, builds `features = ["auth"]` and never touched it. Two copies of the same files is a drift surface, and it had already drifted: this crate spent weeks serving a monogram missing its inner 'S' and a styles.css that had lost the whole `.input` family, with nothing red. Deleting the copy removes the failure mode instead of detecting it. Removed: rust/src/ui/, shared/, rust/build.rs (it existed only to generate the tokens module), the serde_json build-dependency, the ../shared/** include entries, and the `ui` feature. `auth` is now the only feature and stays opt-in — it is what the one consumer asks for, and its tree (tokio, reqwest, axum) is heavy enough to be explicit about. Docs rewritten: lib.rs and README described a design-system crate. They now describe an auth library and point at SmooAI/ui for the design system. SmooAI/ui#10 removes the now-pointless shared-drift gate and lands first, so neither repo has a red window. Verified: cargo fmt --check, clippy (default + all-features, --all-targets -D warnings), cargo test --all-features (28 passed), check-module-tree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of 2 resolving the
ui/client-sharedduplication (pearl th-596512). Merge SmooAI/ui#10 first — it removes the drift gate that reads the directory this PR deletes.Why
This crate carried a byte-identical copy of
SmooAI/ui's design system and called itself that crate's successor. The migration was never finished, and an org-wide code search settles who actually needs what:smooai_client_shared::uismooai_client_shared::auththCLIsmooai-uiTwo copies of the same files is a drift surface, and it had already drifted: this crate spent weeks serving a monogram with no inner 'S' and a
styles.cssmissing the entire.inputfamily, with nothing red. Deleting the copy removes the failure mode rather than detecting it.What's removed
rust/src/ui/andshared/— the duplicate design system.rust/build.rsand theserde_jsonbuild-dependency — they existed only to generate the tokens module.../shared/**entries ininclude, and theuifeature.authbecomes the only feature and stays opt-in. It's what the one consumer asks for, but its tree (tokio, reqwest, axum) is heavy enough to be explicit about rather than default.Docs in
lib.rsand the README described a design-system crate; both now describe an auth library and point atSmooAI/ui.No consumer impact
this rev-pinned and asks forfeatures = ["auth"], which is unchanged. smooblue and observability-studio never depended on this crate at all.Verified locally
Net: 1,194 deletions, 54 insertions.
🤖 Generated with Claude Code
https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC